David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4133/6/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: Line 459: for (const PeersMap::value_type& peer : peers_map_) { > yea, agreed that it's not a super impactful optimization, but more about co well the all replicated is always supposed to go back when we add a new node, so maybe we can change the name, but its nature seems to be necessary :) agreed on the follow on. http://gerrit.cloudera.org:8080/#/c/4133/7/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: Line 267: // changes, so the refactor isn't trivial. final q: do you think it might be worth it to just look at the last message, like we did before and then reverse iterate only if the term actually changed? -- To view, visit http://gerrit.cloudera.org:8080/4133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2aa294472f018013d88f36a9358e9ebd9d5ed8f8 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
