Will Berkeley has posted comments on this change. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4526/8/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: PS8, Line 241: peer->HumanReadableState() != "TABLET_DATA_TOMBSTONED" nit: could you do the check on the actual state enum values and not a stringified version? Just logically cleaner. See the impl of HumanReadableState for how to do this. -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure <ni...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ninad Shringarpure <ni...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes