Alexey Serbin has posted comments on this change. Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4526/8/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: PS8, Line 241: peer->HumanReadableState() != "TABLET_DATA_TOMBSTONED" > nit: could you do the check on the actual state enum values and not a strin Will, since Ninad did not reply to this comment and this patch is in risk to start conflicting with the current code, I'm thinking of submitting this code as is (actually, I gave it +2 prior). We can address your comment in a separate changelist. -- To view, visit http://gerrit.cloudera.org:8080/4526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ninad Shringarpure <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ninad Shringarpure <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
