Sailesh Mukil has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4724/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: PS1, Line 103: Status MessengerBuilder::Build(shared_ptr<Messenger> *msgr) { : RETURN_NOT_OK(SaslInit(kSaslAppName)); // Initialize SASL library before we start making requests : gscoped_ptr<Messenger> new_msgr(new Messenger(*this)); : Status build_status = new_msgr.get()->Init(); : if (!build_status.ok()) { : new_msgr.get()->AllExternalReferencesDropped(); : > I think in the case of an error you'd want to just call AllExternalReferenc Yes of course, don't know what I was thinking. I've merged both the functions now. -- To view, visit http://gerrit.cloudera.org:8080/4724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6021587c746af53305b3f601bb1bcc19f63eab0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
