Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure ......................................................................
KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure If Messenger::Init() fails in a debug build, a CHECK() will happen on the destruction of the Messenger object. This happens beacuse, on an error, the Messenger is not Shutdown(). This patch gets rid of the private function Messenger::Build(Messenger**) and moves all its logic into the public function Build(shared_ptr<Messenger>*). On an error, an explicit call to AllExternalReferencesDropped() is made. This case was probably never encountered as Messenger::Init() currently has a very low chance of failing. However, in the future, as more things may get added on to the function, this issue might show up more often. A more detailed explanation is given in the JIRA. Change-Id: Id6021587c746af53305b3f601bb1bcc19f63eab0 Reviewed-on: http://gerrit.cloudera.org:8080/4724 Reviewed-by: Todd Lipcon <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/rpc/messenger.cc M src/kudu/rpc/messenger.h 2 files changed, 7 insertions(+), 11 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6021587c746af53305b3f601bb1bcc19f63eab0 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
