Todd Lipcon has posted comments on this change.

Change subject: KUDU-1700: Debug build will not fail gracefully on 
Messenger::Init() failure
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4724/1/src/kudu/rpc/messenger.cc
File src/kudu/rpc/messenger.cc:

PS1, Line 103: Status MessengerBuilder::Build(Messenger **msgr) {
             :   RETURN_NOT_OK(SaslInit(kSaslAppName)); // Initialize SASL 
library before we start making requests
             :   gscoped_ptr<Messenger> new_msgr(new Messenger(*this));
             :   *msgr = new_msgr.release();
             :   RETURN_NOT_OK((*msgr)->Init());
             :   return Status::OK();
             : }
since this is just a private method called from one place, maybe we should just 
move all of this into the other Build? With this re-ordering you've done it 
looks like a buggy function since our usual policy is that if it's a bad status 
then nothing happens in the out-params. Any reason not to merge the two 
functions?


-- 
To view, visit http://gerrit.cloudera.org:8080/4724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6021587c746af53305b3f601bb1bcc19f63eab0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to