Sailesh Mukil has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4724/2/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: Line 106: Status build_status = new_msgr->Init(); > warning: redundant get() call on smart pointer [google-readability-redundan Done Line 108: new_msgr->AllExternalReferencesDropped(); > warning: redundant get() call on smart pointer [google-readability-redundan Done -- To view, visit http://gerrit.cloudera.org:8080/4724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6021587c746af53305b3f601bb1bcc19f63eab0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
