Maxim Smyatkin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4733

Change subject: KUDU-1696. Daemons should dump their version info to the INFO 
log at startup
......................................................................

KUDU-1696. Daemons should dump their version info to the INFO log at startup

In addition to adding full version info on tserver and master startup,
I've added logging of command line arguments as suggested in the ticket.
Although the initial idea was to log only flags different from their defaults,
I merely implemented logging of all given command line arguments (after they're
successfully parsed by GFlags).
The reasons are: a) some flags differ from their defaults explicitly,
like FLAG_rpc_bind_addresses in master_main.cc, and b) others do it
that way and it seems good enough, right?
Here is what it looks like in ts log now, for example:

I1016 23:17:21.764128 10547 tablet_server_main.cc:55] Tablet server executed 
with:
--unlock_experimental_flags
--log_dir=/tmp/kudu/whzdP6lK
--fs_wal_dir=/tmp/kudu/whzdP6lK/ts
--fs_data_dirs=/tmp/kudu/whzdP6lK/ts
--rpc_bind_addresses=127.0.0.1
--local_ip_for_outbound_sockets=127.0.0.1
--webserver_interface=localhost
--webserver_port=8051
--tserver_master_addrs=127.0.0.1
Tablet server version:
kudu 1.1.0-SNAPSHOT
revision 0c52f161b4504480adcb9e06b7bb0bc5b3e192b0-dirty
build type RELEASE
built by max at 16 Oct 2016 16:24:01 MSK on destr-workspace

Change-Id: I846827c53e74ca364af61c690bf85af8a8f28601
---
M src/kudu/master/master_main.cc
M src/kudu/tserver/tablet_server_main.cc
M src/kudu/util/CMakeLists.txt
A src/kudu/util/flags-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
6 files changed, 95 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/4733/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I846827c53e74ca364af61c690bf85af8a8f28601
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Maxim Smyatkin <smyatkinma...@gmail.com>

Reply via email to