Todd Lipcon has posted comments on this change. Change subject: KUDU-1696. Daemons should dump their version info to the INFO log at startup ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4733/2/src/kudu/util/flags.cc File src/kudu/util/flags.cc: Line 360: string FormatCommandLineFlags(int argc, char** argv) { the problem with this is that it won't dump flags that are specified from a flagsfile. For daemons, it's often the case that the only command line flag is --flagsfile /foo/bar, so it would be good to dump those, even if it means that we might also end up dumping a few things where we overrode default. -- To view, visit http://gerrit.cloudera.org:8080/4733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I846827c53e74ca364af61c690bf85af8a8f28601 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Maxim Smyatkin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
