Todd Lipcon has posted comments on this change. Change subject: KUDU-1696. Daemons should dump their version info to the INFO log at startup ......................................................................
Patch Set 5: (1 comment) one tiny formatting nit, otherwise looks good! http://gerrit.cloudera.org:8080/#/c/4733/5/src/kudu/util/flags.cc File src/kudu/util/flags.cc: PS5, Line 373: flag.current_value != default_flag->second.current_value) { : if (!args.str().empty()) { : args << '\n'; : } : args << "--" << flag.name << '=' << flag.current_value; nit: indentation is off here -- the second line of the if() should line up with the first condition, and the body of the if is indented 2 spaces too many I think -- To view, visit http://gerrit.cloudera.org:8080/4733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I846827c53e74ca364af61c690bf85af8a8f28601 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Maxim Smyatkin <smyatkinma...@gmail.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Maxim Smyatkin <smyatkinma...@gmail.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
