Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4733

to look at the new patch set (#3).

Change subject: KUDU-1696. Daemons should dump their version info to the INFO 
log at startup
......................................................................

KUDU-1696. Daemons should dump their version info to the INFO log at startup

In addition to adding full version info on tserver and master startup,
I've added logging of command line arguments as suggested in the ticket.
Using flags before ParseCommandLineFlags() as defaults, I've been able to filter
out from output any flags set explicitly in source code or values set to their 
defaults
in command line.
Here is what it looks like in ts log now, for example:

I1016 23:17:21.764128 10547 tablet_server_main.cc:55] Tablet server executed 
with:
--fs_data_dirs=/tmp/kudu/5VmpWrWo/ts
--fs_wal_dir=/tmp/kudu/5VmpWrWo/ts
--rpc_bind_addresses=127.0.0.1
--webserver_interface=localhost
--webserver_port=8051
--tserver_master_addrs=127.0.0.1
--heap_profile_path=/tmp/kudu-tserver.7060
--unlock_experimental_flags=true
--local_ip_for_outbound_sockets=127.0.0.1
--log_dir=/tmp/kudu/5VmpWrWo
Tablet server version:
kudu 1.1.0-SNAPSHOT
revision de38975ba220d57f241416b61ac1ecb40f2de75a-dirty
build type RELEASE
built by max at 19 Oct 2016 00:56:30 MSK on destr-workspace

Change-Id: I846827c53e74ca364af61c690bf85af8a8f28601
---
M src/kudu/master/master_main.cc
M src/kudu/tserver/tablet_server_main.cc
M src/kudu/util/CMakeLists.txt
A src/kudu/util/flags-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
6 files changed, 168 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/4733/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I846827c53e74ca364af61c690bf85af8a8f28601
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Maxim Smyatkin <smyatkinma...@gmail.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to