Dan Burkert has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4752/1/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: Line 44: realm_(options.realm.empty() ? "KRBTEST.COM" : options.realm), > Not done? As discussed, the GetTestDataDirectory() needs to get called after the MiniKdcOptions ctor. Line 54: vector<string> MiniKdc::MakeArgv(const vector<string>& in_argv) { > Yes? No? Yes, but I'd rather not do it in this patch. Line 85: RETURN_NOT_OK(CreateKrb5Conf()); > I see. Two things: 1) CreateKrb5Conf is private, is that good enough? 2) It's explained below, where it's called the second time. Line 230: RETURN_NOT_OK(GetBinaryPath("lsof", {"/sbin"}, &lsof)); > You're right; I meant, perhaps we can just run lsof with PATH=/sbin:$PATH a The three-arg call to GetBinaryPath doesn't reuse the default vector of common locations, so this is exactly the same as calling with PATH=/sbin:$PATH. -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
