Dan Burkert has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4752/4/src/kudu/security/mini_kdc-test.cc File src/kudu/security/mini_kdc-test.cc: PS4, Line 18: #include <gtest/gtest.h> : #include <string> : : #include "kudu/security/mini_kdc.h" : #include "kudu/util/test_util.h" > Nit: by the style guide https://google.github.io/styleguide/cppguide.html#N Done http://gerrit.cloudera.org:8080/#/c/4752/3/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS3, Line 220: $1 = { > I don't know much about this, but I would think if client is given the same I haven't tested either, but since the kdc_ports="" option is set in the kdc.conf and not krb5.conf, I think there is a good chance that the client will not use it. http://gerrit.cloudera.org:8080/#/c/4752/4/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS4, Line 18: #include "kudu/security/mini_kdc.h" : : #include <csignal> : #include <cstdio> : #include <glog/logging.h> : #include <limits> : #include <memory> : #include <string> : : #include "kudu/gutil/gscoped_ptr.h" : #include "kudu/gutil/strings/numbers.h" : #include "kudu/gutil/strings/split.h" : #include "kudu/gutil/strings/strip.h" : #include "kudu/gutil/strings/substitute.h" : #include "kudu/util/env.h" : #include "kudu/util/monotime.h" : #include "kudu/util/path_util.h" : #include "kudu/util/subprocess.h" : #include "kudu/util/test_util.h" > Nit: by the style guide https://google.github.io/styleguide/cppguide.html#N Done http://gerrit.cloudera.org:8080/#/c/4752/4/src/kudu/security/mini_kdc.h File src/kudu/security/mini_kdc.h: PS4, Line 20: #include <glog/logging.h> : #include <memory> : #include <string> : #include <vector> : : #include "kudu/util/status.h" > Nit: by the style guide https://google.github.io/styleguide/cppguide.html#N Done -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
