Dan Burkert has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/4752/6/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: Line 106: static const vector<string> kCommonLocations = { > This isn't in sync with FindKdc.cmake. FindKdc is only looking for the krb5kdc binary, which is only expected to be in sbin/. This method is also used to look for kinit/klist, which can be in bin/. PS6, Line 123: << " realm: " << options_.realm : << " port: " << options_.port : << " data_root: " << options_.data_root; > Nit: may be cleaner to encapsulate this as ToString() in MiniKdcOptions; th Done Line 277: options_.port = port; > Hmm, this one we may want to store separately, so we can remember that the In what circumstances would that be useful? http://gerrit.cloudera.org:8080/#/c/4752/6/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: PS6, Line 116: // Writes enough bytes to stdout and stderr concurrently that if Call() were : // fully reading them one at a time, the test would deadlock. > I understand that it was easy to piggy-back on this test, but it was explic Done PS6, Line 118: StdIn > Nit: Stdin Done http://gerrit.cloudera.org:8080/#/c/4752/6/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: Line 531: const string& stdin_in) { > If we want to support arbitrarily large stdin values, I think we'll need to I can't forsee needing that; I've documented the 64k limit. http://gerrit.cloudera.org:8080/#/c/4752/6/src/kudu/util/subprocess.h File src/kudu/util/subprocess.h: PS6, Line 108: subprocesses > Nit: subprocess' Done Line 112: const std::string& stdin_in = ""); > Nit: would prefer if stdin came first. Why? Done -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
