Todd Lipcon has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4752/6/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: Line 277: options_.port = port; > In what circumstances would that be useful? yea I'm skeptical of the use here, I think we should be usecase-driven in terms of adding functionality to the minicluster. In fact I dont know if we really have any use for specifying port at all (not that we need to change it now). Think we should try to get this committed ASAP and then change it as we need new stuff in it. -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
