Alexey Serbin has posted comments on this change. Change subject: rpc: improve error messages and logging for bad authentication ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4764/3/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: PS3, Line 246: (s.IsNotAuthorized()) nit: unneeded extra braces. Besides, I think it could be more readable if written as: bool is_bad = !s.ok() && !( (s.IsNetworkError() && s.posix_code() == ECONNREFUSED) || s.IsNotAuthorized()); Or: bool is_good = s.ok() || s.IsNotAuthorized() || (s.IsNetworkError() && s.posix_code() == ECONNREFUSED); -- To view, visit http://gerrit.cloudera.org:8080/4764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5156b09fa4f8c7591f4e399ce8cc450c089e88 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
