Todd Lipcon has posted comments on this change. Change subject: rpc: improve error messages and logging for bad authentication ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4764/2/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: Line 215: CHECK_EQ(0, regcomp(&re, > I'm a little worried about CHECK here. The server could get send a message but this is the compilation of the constant regex, not the _matching_ of the regex. So, it would only fail with a regex with invalid syntax, or OOM or something. -- To view, visit http://gerrit.cloudera.org:8080/4764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5156b09fa4f8c7591f4e399ce8cc450c089e88 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
