Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4764
to look at the new patch set (#4).
Change subject: rpc: improve error messages and logging for bad authentication
......................................................................
rpc: improve error messages and logging for bad authentication
* Don't dump the trace for a failed authentication exchange.
* Improve the error messages for GSSAPI failures to only include the
interesting bit.
* Don't log all authentication failures at ERROR level. Instead, capture
the error log message and pass it back to the caller of the SASL API
through a thread-local hack.
Both clients and servers have provisions to log failed negotiations
elsewhere, so the log message coming from this context is redundant;
however, the error text that is passed here is more descriptive than
the error returned by sasl_errstring().
Change-Id: I3a5156b09fa4f8c7591f4e399ce8cc450c089e88
---
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/sasl_client.cc
M src/kudu/rpc/sasl_client.h
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/rpc/sasl_server.cc
7 files changed, 186 insertions(+), 102 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/4764/4
--
To view, visit http://gerrit.cloudera.org:8080/4764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a5156b09fa4f8c7591f4e399ce8cc450c089e88
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
