Todd Lipcon has posted comments on this change. Change subject: rpc: improve error messages and logging for bad authentication ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/4764/4/src/kudu/rpc/sasl_client.h File src/kudu/rpc/sasl_client.h: PS4, Line 135: Incopmlete > nit: typo Done http://gerrit.cloudera.org:8080/#/c/4764/4/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: PS4, Line 34: #include "kudu/util/scoped_cleanup.h" > nit: not sure whether this header is necessary here. Done PS4, Line 198: re > What about calling regfree()? Is LSAN happy without that? yea, LSAN appears to not be complaining. If it does at some point later we can add a LeakCheckDisabler, but I think it's happy because there is static storage pointing at the allocated object PS4, Line 249: Status::NotAuthorized > Does it make sense to return something else here instead? I.e., there migh I broke out the list of expected "authorization" failures here, but unfortunately missing krb5 credentials shows up as SASL_FAIL, which is pretty generic. But at least now something like memory errors will show up as RuntimeError. http://gerrit.cloudera.org:8080/#/c/4764/4/src/kudu/rpc/sasl_server.cc File src/kudu/rpc/sasl_server.cc: PS4, Line 450: SaslMessagePB msg > That might be not relevant to the scope of this patch, but it seems this va Done -- To view, visit http://gerrit.cloudera.org:8080/4764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5156b09fa4f8c7591f4e399ce8cc450c089e88 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
