Todd Lipcon has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4800/2/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: Line 1019: return Status::OK(); nit: now this function always returns Status::OK. Mind either propagating the change so this is void, or at least add a TODO here to do so? http://gerrit.cloudera.org:8080/#/c/4800/2/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: Line 520: Status SysCatalogTable::ReqAddTablets(WriteRequestPB* req, same here, this now always returns OK http://gerrit.cloudera.org:8080/#/c/4800/2/src/kudu/tablet/deltafile.cc File src/kudu/tablet/deltafile.cc: Line 165: return Status::OK(); and here http://gerrit.cloudera.org:8080/#/c/4800/2/src/kudu/util/pb_util-internal.h File src/kudu/util/pb_util-internal.h: Line 59: Status GetStatus() const { style: should just be called 'status()' -- To view, visit http://gerrit.cloudera.org:8080/4800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib760793f6e6da3e357573e525f47b32c79472468 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Maxim Smyatkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Maxim Smyatkin <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
