Adar Dembo has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4800/1//COMMIT_MSG Commit Message: PS1, Line 10: wais Nit: ways http://gerrit.cloudera.org:8080/#/c/4800/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: Line 441: table->metadata().dirty().name())); Let's actually use the table ID here. It's more consistent with the other failure cases (where we prepend either the table or tablet ID). Also, table names can be considered sensitive user information that shouldn't be logged (though we have a lot of work to do to fix this). http://gerrit.cloudera.org:8080/#/c/4800/1/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: Line 443: return Status::Corruption("Error parsing msg", InitializationErrorMessage("parse", *msg)); This is the only case I don't understand; how could msg->ParseFromZeroCopyStream() return false, yet istream.GetStatus() return Status::OK()? -- To view, visit http://gerrit.cloudera.org:8080/4800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib760793f6e6da3e357573e525f47b32c79472468 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Maxim Smyatkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
