Dinesh Bhat has posted comments on this change.

Change subject: KUDU-78. Fix pb_util functions which return bool to return 
Status
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4800/1/src/kudu/util/pb_util.cc
File src/kudu/util/pb_util.cc:

Line 431:   return Status::OK();
Few of these routines do not seem to be returning no other value than 
Status::OK, I think we could as well keep these routines' return type as void. 
Otherwise LGTM.


-- 
To view, visit http://gerrit.cloudera.org:8080/4800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib760793f6e6da3e357573e525f47b32c79472468
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Maxim Smyatkin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dinesh Bhat <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to