Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) ......................................................................
Patch Set 10: (2 comments) > (2 comments) > > Would you mind also adding a test that makes sure that attempting > to copy over an existing (running) tablet, even in --force mode, > fails? BTW, this doesn't fail if I am copying over an existing healthy replica with --force, because we set the caller id to INT_MAX from the tool. > Also, I wonder what the value of the --force flag is, since this is > a manual tool maybe we should always force. This seems like a tool > that you would only typically use --force with, so why bother > requiring people to specify it. Precisely the above case, we don't want user to accidentally copy on an existing healthy replica, but if he wants to, we can override using force option. http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: Line 1149 > It's bad that they have different semantics, because they implement the sam Yeah, I root-caused it to be a missing piece in socket teardown path for macOS, but I am gonna fix that in a different patch. http://gerrit.cloudera.org:8080/#/c/4834/9/src/kudu/tools/tool_action_remote_replica.cc File src/kudu/tools/tool_action_remote_replica.cc: Line 331: strings::Substitute("Remote server returned error code $0", > it's generated and placed in build/latest/src/kudu/tserver/tserver.pb.cc Yeah, I was more curious about what makes this Enum special ? It turns out the protobuf always generate one such routines for Enum types, that's cool :) -- To view, visit http://gerrit.cloudera.org:8080/4834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113a25e9b6c14f7c3814140917b61e35030b58d0 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
