Hao Hao has posted comments on this change. Change subject: Reject CREATE TABLE ops with even replication factor ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4945/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS2, Line 120: TAG_FLAG(allow_unsafe_replication_factor > Does it make sense to mark it as advanced as well? Based on the flag_tags.h comments "/ - "advanced": // These flags are for advanced users or debugging purposes. While // they aren't likely to be actively harmful (see "unsafe" below), // they're also likely to be used only rarely and should be relegated // to more detailed sections of documentation. // // - "unsafe": // These flags are for internal use only (e.g. testing), and changing // them away from the defaults may result in arbitrarily bad things // happening. These flags are automatically excluded from user-facing // documentation even if they are not also marked 'hidden'. // // Users must pass --unlock_unsafe_flags to use any of these // flags." It make sense just to mark it unsafe, since I think even replication factor is only for testing? -- To view, visit http://gerrit.cloudera.org:8080/4945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
