Todd Lipcon has posted comments on this change. Change subject: KUDU-1658: Reject CREATE TABLE ops with even replication factor ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4945/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS6, Line 120: table nit: should be "Allow creating creating tables with an even replication factor." PS6, Line 933: s. U nit: should be ", unless master flag..." PS6, Line 936: Reject CREATE TABLE with even replication " : "factor nit: doesn't match our normal style for user-facing error messages. I would say something like "illegal replication factor $0 (replication factor must be odd)" -- To view, visit http://gerrit.cloudera.org:8080/4945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
