Alexey Serbin has posted comments on this change. Change subject: Reject CREATE TABLE ops with even replication factor ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4945/4/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: PS4, Line 584: nit: it seems a tab is used here instead of spaces. http://gerrit.cloudera.org:8080/#/c/4945/4/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: PS4, Line 412: vector<string> ts_flags, master_flags; : ts_flags.push_back("--enable_leader_failure_detection=false"); : master_flags.push_back("--catalog_manager_wait_for_new_tablets_to_elect_leader=false"); : master_flags.push_back("--allow_unsafe_replication_factor=true"); nit: while you at it, could you update this to use the initializer lists instead of push_back() calls? http://gerrit.cloudera.org:8080/#/c/4945/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS2, Line 120: "Allow creating table with > Based on the flag_tags.h comments "/ - "advanced": ok, as I understand, with this semantics 'unsafe' is a stronger case of 'advanced', so no other specifiers are required. http://gerrit.cloudera.org:8080/#/c/4945/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS4, Line 120: nit: an extra space -- To view, visit http://gerrit.cloudera.org:8080/4945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
