Jean-Daniel Cryans has posted comments on this change. Change subject: [c++ client] implemented session operations stats ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG Commit Message: PS2, Line 10: > That's intentional -- two spaces after a stop makes it easier to read, IMO. It made it easier to read when using typewriters but that's a long time ago :) I'm strongly in favor of not using double spaces anywhere, commit messages are no different than code to me. http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/client.h File src/kudu/client/client.h: PS2, Line 1504: CountTotalOperations > Yep, that makes sense. However, I don't like the idea having long names a Yeah that sounds good. http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: PS2, Line 326: write_op_stats_->IncFailed(); > The idea was to provide stats based on total calls of the Apply() method: w I'm in favor of consistency, or at least to document the discrepancy. -- To view, visit http://gerrit.cloudera.org:8080/4974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4191105158f49d811763fdc8e82831b4e2e0be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
