Alexey Serbin has posted comments on this change. Change subject: [c++ client] implemented session operations stats ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG Commit Message: PS2, Line 10: > It made it easier to read when using typewriters but that's a long time ago That hasn't changed since then -- people's eyes does not evolve with the tech :) As I understand, the only case when it does not make difference is HTTP or some other text processing where the end-result does not contain the original formatting. In that case yes -- it does not make sense to have extra spaces since the text is re-formatted anyway. But for source code and commit messages which are displayed verbatim even in IDEs/browsers, that does make sense. However, if we want to have single-spaces everywhere, I'll update this. But there is one other place where two spaces are used in every source code file: the Apache license :) http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/client.h File src/kudu/client/client.h: PS2, Line 1504: CountTotalOperations > Yeah that sounds good. All right, I'm going to use total_write_ops() and failed_write_ops(). http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: PS2, Line 326: write_op_stats_->IncFailed(); > I'm in favor of consistency, or at least to document the discrepancy. ok, I'll add comments and corresponding test as well. -- To view, visit http://gerrit.cloudera.org:8080/4974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4191105158f49d811763fdc8e82831b4e2e0be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
