Alexey Serbin has posted comments on this change. Change subject: [c++ client] implemented session operations stats ......................................................................
Patch Set 2: > Alexey, thanks for doing this. As we discussed, one of the issues > Impala faces is that the error codes are too coarse grained right > now, so we can't differentiate some important error cases. I think > this mechanism will be useful when it can also include breakdowns > of the errors, more fine-grained than the error codes (which may > need to remain as-is for backwards compatibility). However, until > we can report the breakdown into more fine grained error stats, I > don't think Impala will use this over the GetErrorStats, so it's up > to you if you'd wanna still get this in in the meantime or shelve > the change for later. All right, thanks for the clarification. The part with the custom error info requires more time, and I think I can start working on that once we are done with the security-related stuff. Meanwhile, we can add this path independently. -- To view, visit http://gerrit.cloudera.org:8080/4974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4191105158f49d811763fdc8e82831b4e2e0be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
