Adar Dembo has posted comments on this change. Change subject: [c++ client] implemented session operations stats ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/client.h File src/kudu/client/client.h: Line 1503: /// @return Total count of write operations in the session. What do you think of reusing kudu::client::ResourceMetrics for this purpose? http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/error_collector.cc File src/kudu/client/error_collector.cc: Line 21: #include <type_traits> What is this for? http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/write_op_stats.h File src/kudu/client/write_op_stats.h: Line 20: #include <atomic> I think the jury is still out regarding std::atomic vs. our built-in atomics. See http://gerrit.cloudera.org:8080/1842 for more details. I suggest that, outside of unit tests, we continue to use built-in atomics. -- To view, visit http://gerrit.cloudera.org:8080/4974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4191105158f49d811763fdc8e82831b4e2e0be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
