Adar Dembo has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG Commit Message: PS1, Line 14: 2. The ticket cache is now the default FILE type instead of DIR. This : has the downside of limiting our MiniKdc to one kinitted user, but : heimdal apparently has issues with DIR, and FILE is expected to be how : normal users will use Kerberos. Is this downside worth the trade-off? Seems like having multiple kinitted users is something we'd want to test at some point. An alternative would be to disable Kerberos tests on macOS. Or maybe use FILE on macOS and DIR elsewhere. http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: PS1, Line 285: get-pricipal It's really not 'get-principal'? Also, can we define the path centrally and use it both here and in test_util.cc? http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/security/test/mini_kdc-test.cc File src/kudu/security/test/mini_kdc-test.cc: Line 47: ASSERT_OK(kdc.Kinit("bob")); Doesn't this contradict your commit description? I thought using a FILE cache meant that a single UNIX user could only kinit as one kerberos user? -- To view, visit http://gerrit.cloudera.org:8080/4978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b61af8cedf83745a5b7a6b806b68912f2655821 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
