Dan Burkert has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG Commit Message: PS1, Line 14: 2. The ticket cache is now the default FILE type instead of DIR. This : has the downside of limiting our MiniKdc to one kinitted user, but : heimdal apparently has issues with DIR, and FILE is expected to be how : normal users will use Kerberos. > That's fair, but in effect this punts a certain class of testing out of int Right now we have no tests that rely on multiple kinit'd users, except for the unit test which I modified. In the future we could keep separate FILE type ticket locations for each individual client we want to kinit, but they would have to be in separate processes. http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: PS1, Line 285: get-pricipal > It's really not 'get-principal'? Yah this seems to be a typo in Heimdal. Is it possible to splice in a constant to a literal const char*? I've never seen that done. http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/security/test/mini_kdc-test.cc File src/kudu/security/test/mini_kdc-test.cc: Line 47: ASSERT_OK(kdc.Kinit("bob")); > Doesn't this contradict your commit description? I thought using a FILE cac bob overwrites alice here, so alice is no longer kinit'd -- To view, visit http://gerrit.cloudera.org:8080/4978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b61af8cedf83745a5b7a6b806b68912f2655821 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
