Alexey Serbin has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4978/3/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: Line 220: #if defined(__APPLE__) Does it make sense to differentiate based on gss-api version instead? E.g., using pkgconfig it might be possible to retrieve version of the package and put it into the compilation flags. Or it's not related to the version of gss-api at all? -- To view, visit http://gerrit.cloudera.org:8080/4978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b61af8cedf83745a5b7a6b806b68912f2655821 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
