Adar Dembo has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: PS1, Line 285: get-pricipal > Yah this seems to be a typo in Heimdal. If it's too weird, just convert this into a std::string. It's a unit test so string literal vs. std::string doesn't really matter. http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/security/test/mini_kdc-test.cc File src/kudu/security/test/mini_kdc-test.cc: Line 47: ASSERT_OK(kdc.Kinit("bob")); > bob overwrites alice here, so alice is no longer kinit'd Can we confirm that in the test? By ensuring the [email protected] isn't in the klist output? -- To view, visit http://gerrit.cloudera.org:8080/4978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b61af8cedf83745a5b7a6b806b68912f2655821 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
