Dan Burkert has posted comments on this change. Change subject: KUDU-1749. Allow callers to disable SASL initialization ......................................................................
Patch Set 2: (2 comments) Here's a patch to make this work with OS X: https://gist.github.com/anonymous/bc2d7fe7769cd50239ce1a27bec7d497 http://gerrit.cloudera.org:8080/#/c/5120/2//COMMIT_MSG Commit Message: PS2, Line 19: Impala has initialized the SASL library with no : call to sasl_set_mutex(), and then during Kudu initialization we set the : mutex functions to our own. Has Impala been fixed? If not, this patch still won't work correctly since it will fail when the mutex check is done. http://gerrit.cloudera.org:8080/#/c/5120/2/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: Line 203: LOG(WARNING) << "SASL was initialized prior to Kudu's initialization. Skipping " I think I would be in favor of making this a hard error. -- To view, visit http://gerrit.cloudera.org:8080/5120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54d5ecfb2526852003f1ea249d1d2a8e6c0e91cd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
