Todd Lipcon has posted comments on this change. Change subject: KUDU-1749. Allow callers to disable SASL initialization ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5120/1//COMMIT_MSG Commit Message: PS1, Line 29: - we try to auto-detect the case in which the client has fully : initialized SASL including providing a mutex implementation. In that : case, we skip initialization but log a warning that the caller should : disable it explicitly. : - if we detect that it's initialized but no mutex implementation is : provided, we'll return an error on first usage of SASL. Similarly, if : they disable initialization but didn't do a proper job of : initialization, we detect it and return an error on usage. > what about also offering a way to explicitly enable as well, then you also I started writing the code for this, and when I got to documenting the API I couldn't really explain why you'd want to force initialization on even if we detect that it's already initialized. If we run into such a problem I think I'd rather have the user hit an issue and report it and get it fixed rather than work around it (and us continue to ship flaky auto-detection code) Do you feel strongly? -- To view, visit http://gerrit.cloudera.org:8080/5120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54d5ecfb2526852003f1ea249d1d2a8e6c0e91cd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
