Adar Dembo has posted comments on this change. Change subject: KUDU-1749. Allow callers to disable SASL initialization ......................................................................
Patch Set 3: (2 comments) Mostly just wanted to look at the API changes. http://gerrit.cloudera.org:8080/#/c/5120/3/src/kudu/client/client.h File src/kudu/client/client.h: PS3, Line 132: SASL Only if the client is also using the Cyrus SASL library, right? In theory there are other SASL implementations for which there'd be no overlap at all? http://gerrit.cloudera.org:8080/#/c/5120/3/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sasl_rpc-test.cc: PS3, Line 511: executable_path, : "test", : filter_flag, : "--is_test_child"}, Nit: indentation is strangely unaligned here. -- To view, visit http://gerrit.cloudera.org:8080/5120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54d5ecfb2526852003f1ea249d1d2a8e6c0e91cd Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
