Todd Lipcon has posted comments on this change. Change subject: KUDU-1749. Allow callers to disable SASL initialization ......................................................................
Patch Set 3: Chatted offline with MJ from the Impala team. He asked me to make it a WARNING instead of returning a bad Status in the case that Impala inits SASL but doesn't initialize the SASL mutexes. Both Impala and Kudu through 1.0 neglected to set up mutexes and have never seen a problem, so we don't think it's 100% critical. And there's some fear it could cause an unexpected perf issue to enable it now. So, we want to stage the change -- this patch will just make it a WARNING and unbreak the integration, and then they'll separately test the sasl_set_mutex() addition separately. -- To view, visit http://gerrit.cloudera.org:8080/5120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54d5ecfb2526852003f1ea249d1d2a8e6c0e91cd Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
