Todd Lipcon has posted comments on this change. Change subject: Implement fix for KUDU-1493 ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5167/1//COMMIT_MSG Commit Message: Line 7: Implement fix for KUDU-1493 nit: please use the format: --- KUDU-1493: <short summary> <long summary of problem and approach taken in the patch> --- so that when we look at a git log it's easier to understand what the commit did without having to go read the JIRA. http://gerrit.cloudera.org:8080/#/c/5167/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: Line 102: override def createRelation(sqlContext: SQLContext, parameters: Map[String, String], schema: StructType): BaseRelation = { nit: do you mind wrapping these lines to 100 columns max? PS1, Line 102: override def createRelation(sqlContext: SQLContext, parameters: Map[String, String], schema: StructType): BaseRelation = { (a few other places too) -- To view, visit http://gerrit.cloudera.org:8080/5167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6073256b61a174f898be222058277be976273c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Manlove <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
