Chris George has posted comments on this change. Change subject: KUDU-1493: Implement SchemaRelationProvider ......................................................................
Patch Set 3: (1 comment) overall I think it looks good... we should update the @param on KuduRelation Would also be good to update the examples in the docs http://gerrit.cloudera.org:8080/#/c/5167/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: Line 124: * @param sqlContext SparkSQL context update comments -- To view, visit http://gerrit.cloudera.org:8080/5167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6073256b61a174f898be222058277be976273c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Manlove <[email protected]> Gerrit-Reviewer: Chris George <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
