Dan Burkert has posted comments on this change. Change subject: block manager: start using the file cache ......................................................................
Patch Set 3: code looks good, going to jot down some notes we discussed offline: * Make sure this handles the case where the ulimit is unlimited * Consider adding a mandatory minimum ulimit with an unsafe escape hatch flag in order to avoid situations where Kudu thrashes on an extremely low number of files * It would be nice to see a benchmark comparing number of file descriptors vs. performance on something like YCSB (which is a workload I would expect would be dependent on accessing many blocks) -- To view, visit http://gerrit.cloudera.org:8080/5147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeefd31eca340111bc535eac1f982290e7703a88 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
