Dinesh Bhat has posted comments on this change. Change subject: block manager: start using the file cache ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS4, Line 366: OpenExistingRWFile I am curious to know what's the challenge in driving the new file creation through the FileCache(assuming we add a support for that in FileCache) @L350 instead of creating first and then opening through cache. I saw the COMMIT_MSG mentioning it too but didn't understand the reasons behind it. -- To view, visit http://gerrit.cloudera.org:8080/5147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeefd31eca340111bc535eac1f982290e7703a88 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
