Adar Dembo has posted comments on this change. Change subject: block manager: start using the file cache ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS4, Line 366: OpenExistingRWFile > I am curious to know what's the challenge in driving the new file creation What makes it messy is the need for the cache to use one opening mode (CREATE_NON_EXISTING) when opening the file for the very first time, then use a different one (OPEN_EXISTING) for subsequent opens. It's more per-file state for this one small use case, so it didn't seem worth it. Since then, Dan suggested I templatize the file cache, which makes this one-off for RWFiles a little weirder still. -- To view, visit http://gerrit.cloudera.org:8080/5147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeefd31eca340111bc535eac1f982290e7703a88 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
