Dan Burkert has posted comments on this change. Change subject: block manager: start using the file cache ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/block_manager.cc File src/kudu/fs/block_manager.cc: Line 61: static std::once_flag once; > So, WARN if the gflag value is higher than GetOpenFileLimit()? Yeah, I can I think WARN at a minimum, I was suggesting FATAL, since it seems like a time bomb waiting to go off at peak load. http://gerrit.cloudera.org:8080/#/c/5147/8/src/kudu/fs/block_manager.cc File src/kudu/fs/block_manager.cc: Line 43: TAG_FLAG(block_manager_max_open_files, advanced); Should we mark this as unstable/evolving? I can imagine we would want to revert to always using the file cache once we prove it's stable. -- To view, visit http://gerrit.cloudera.org:8080/5147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeefd31eca340111bc535eac1f982290e7703a88 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
