Dan Burkert has posted comments on this change. Change subject: WIP: [iwyu] first pass ......................................................................
Patch Set 5: (5 comments) Only got through about 20% of the files, but it looks like there are some cases where headers are getting included unnecessarily (I noticed a few cases of glog/logging.h and int128.h). Is this down to peculiarities with IWYU, or misconfiguration, or something else? http://gerrit.cloudera.org:8080/#/c/4738/5//COMMIT_MSG Commit Message: Line 15: As a result, time of compilation reduced ~10% if building with GNU make Nice! http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/benchmarks/tpch/rpc_line_item_dao.h File src/kudu/benchmarks/tpch/rpc_line_item_dao.h: Line 24: #include <boost/function.hpp> // IWYU pragma: keep Is this due to a bug in IWYU? Could boost/function_fwd.hpp help? http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/benchmarks/tpch/tpch-schemas.h File src/kudu/benchmarks/tpch/tpch-schemas.h: Line 25: #include <glog/logging.h> // for CHECK_OK to be picked up in status.h Why not include glog/logging.h in status.h? http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/cfile/binary_prefix_block.h File src/kudu/cfile/binary_prefix_block.h: Line 26: #include <glog/logging.h> It looks like glog/logging.h is getting included in a bunch of places, I presume just for the hidden dependency in status.h? That seems antithetical to IWYU. http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: Line 50: #include "kudu/gutil/int128.h" This is included here and a few other files, but from a quick glance it doesn't seem necessary. -- To view, visit http://gerrit.cloudera.org:8080/4738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
