Dan Burkert has posted comments on this change. Change subject: WIP: [iwyu] first pass ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/benchmarks/tpch/rpc_line_item_dao.h File src/kudu/benchmarks/tpch/rpc_line_item_dao.h: Line 24: #include <boost/function.hpp> // IWYU pragma: keep > That's more about the IWYU's nature -- it wants you to include the very lea I see, thanks for the reference. http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/cfile/binary_prefix_block.h File src/kudu/cfile/binary_prefix_block.h: Line 26: #include <glog/logging.h> > Here it is for DCHECK() gotcha http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: Line 50: #include "kudu/gutil/int128.h" > Good catch! ah, ok. So this is necessary for logging the block IDs? I didn't realize C++ includes worked that way - I though you only needed the include if the materialized type was present in the file. -- To view, visit http://gerrit.cloudera.org:8080/4738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
