Adar Dembo has posted comments on this change. Change subject: WIP: [iwyu] first pass ......................................................................
Patch Set 5: (3 comments) Just did a scan through, mostly looked at fs/ and tserver/ (for fun). One thing comes to mind: this will bitrot very quickly if IWYU doesn't run precommit (as part of gerrit) to flag bad behavior. How realistic do you think that is right now? http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 38: DECLARE_bool(block_coalesce_close); I wonder why this is here. I can't see a good reason. http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/tserver/scanners-test.cc File src/kudu/tserver/scanners-test.cc: Line 30: #include <gtest/gtest.h> Nit: this belongs before the gutil includes. http://gerrit.cloudera.org:8080/#/c/4738/5/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: Line 25: #include <boost/none.hpp> Nit: belongs in the same grouping as gflags/glog/protobuf. -- To view, visit http://gerrit.cloudera.org:8080/4738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
