Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass ......................................................................
Patch Set 5: > > Also, the codegen test is broken due to some unexpected reason. > I > > need to figure what went wrong with that. But if you are > familiar > > with that part and can guess what's the problem (it could save me > > some time which I would appreciate a lot), see below for the > error: > > > > F1128 19:14:14.026911 2025766912 codegen-test.cc:257] Check > failed: > > _s.ok() Bad status: Configuration error: Code generation for > module > > failed. Could not start ExecutionEngine: Interpreter has not been > > linked in. > > I reproed the codegen-test failure with your patch, then fixed it > with this. I was following > http://comments.gmane.org/gmane.comp.compilers.llvm.devel/42986 > as a guide. That header is...something wacky. Maybe we're missing > some cmake logic that would obviate the need for directly including > MCJIT.h? > > diff --git a/src/kudu/codegen/module_builder.cc > b/src/kudu/codegen/module_builder.cc > index f4d858e..7634577 100644 > --- a/src/kudu/codegen/module_builder.cc > +++ b/src/kudu/codegen/module_builder.cc > @@ -28,6 +28,7 @@ > #include <llvm/ADT/StringMap.h> > #include <llvm/ADT/StringRef.h> > #include <llvm/ExecutionEngine/ExecutionEngine.h> > +#include <llvm/ExecutionEngine/MCJIT.h> > #include <llvm/IR/Constant.h> > #include <llvm/IR/Constants.h> > #include <llvm/IR/DerivedTypes.h> Wow, that's great! Thanks, Adar! Much appreciated! I'll include your patch in the next revision of this patch. I hope with that and small other fixes the tests should pass. -- To view, visit http://gerrit.cloudera.org:8080/4738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
