Todd Lipcon has posted comments on this change. Change subject: bshuf_block: some code cleanup ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/5193/3/src/kudu/cfile/bshuf_block.cc File src/kudu/cfile/bshuf_block.cc: PS3, Line 59: uint32_t value = *cell_ptr(i); : max_value = std::max(max_value, value); > nit: may be, drop the local variable: Done PS3, Line 152: int > hopefully, 'n' cannot be too big yea, we'd never have >2B entries in a block PS3, Line 154: implicit_cast > why cast is needed here at all? This is an unsigned type, so direct assign Done PS3, Line 160: implicit_cast > ditto: I don't think cast is needed here. Done http://gerrit.cloudera.org:8080/#/c/5193/3/src/kudu/cfile/bshuf_block.h File src/kudu/cfile/bshuf_block.h: PS3, Line 155: int > nit: why int, not uint32_t ? google style guide says not to use unsigned types except to represent bit patterns or wire formats, etc. A lot of this code is old from before we started following that rule, which is why there's a bit of inconsistency. Updated this bit of code to be clearer anyway. -- To view, visit http://gerrit.cloudera.org:8080/5193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6857f8096319072eb09be097adea99c45735e0a6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
