Todd Lipcon has posted comments on this change. Change subject: bshuf_block: some code cleanup ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc File src/kudu/cfile/bshuf_block.cc: PS6, Line 152: uint32_t value = array[i]; : memcpy(&array[i * sizeof(uint32_t)], &value, sizeof(value)); > nit: I missed that while doing the review, but memmove() might be a little I don't get the same results you did, and also typically memcpy is faster than memmove because it is able to restrict that the src/dst don't overlap. Let's leave as is unless you can show in a macro-benchmark that it matters. -- To view, visit http://gerrit.cloudera.org:8080/5193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6857f8096319072eb09be097adea99c45735e0a6 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
